github icon indicating copy to clipboard operation
github copied to clipboard

Add ability to add collaborator

Open mtscout6 opened this issue 8 years ago • 2 comments

mtscout6 avatar Jul 16 '17 18:07 mtscout6

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@22b889c). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #462   +/-   ##
=========================================
  Coverage          ?   91.11%           
=========================================
  Files             ?       12           
  Lines             ?      405           
  Branches          ?        0           
=========================================
  Hits              ?      369           
  Misses            ?       36           
  Partials          ?        0
Impacted Files Coverage Δ
lib/Team.js 100% <ø> (ø)
lib/Requestable.js 94.17% <100%> (ø)
lib/Repository.js 80.83% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22b889c...c5c3060. Read the comment docs.

codecov-io avatar Jul 17 '17 03:07 codecov-io

It seems like this API was considered preview? Newer docs have the URL being /repos/:owner/:repo/collaborators/:username, which is the same as the one that was used, so that's nice!

This PR would be easier to review if it didn't also switch the CI and add async await. @clayreimann Is there any plans to change which versions of Node this library builds for? I'm thinking we could merge in the addCollaborator stuff and leave async await for another day.

j-rewerts avatar Apr 07 '19 23:04 j-rewerts