Unity icon indicating copy to clipboard operation
Unity copied to clipboard
verified publisher icon github-for-unity

Fix GitHub sign in with a browser

Open chantzish opened this issue 4 years ago • 4 comments

As of September 8 2021 github removed API authentication through query parameters - https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

As of September 8 2021 github removed API authentication through query parameters - https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/ . Changing to auth via "Authorization: token ..." header.

Alternate Designs

Benefits

Possible Drawbacks

Applicable Issues

chantzish avatar Jan 13 '22 18:01 chantzish

I just had to dig through several issue threads and find the instructions on how to apply this fix myself.

It's been over half a year and this basic functionality is still busted. Please fix this already.

MeirArani avatar Jul 04 '22 06:07 MeirArani

Can we get this merged and a patch release cut?

naim avatar Jul 12 '22 19:07 naim

I can confirm that this bug is still present, and this fix works. Please merge.

ChrisMenning avatar Feb 02 '23 20:02 ChrisMenning

I can also confirm that this bug is still present and that applying this fixes it

Shain-Allen avatar Feb 11 '23 22:02 Shain-Allen