codespaces-teaching-js-template icon indicating copy to clipboard operation
codespaces-teaching-js-template copied to clipboard

🔗 Fix broken URL for Codespace Create button

Open AnthonyByansi opened this issue 1 year ago • 4 comments

This PR fixes the broken URL for the Codespace Creation as observed; image

AnthonyByansi avatar Jul 20 '24 08:07 AnthonyByansi

Hi @alfredodeza, @burkeholland could you please have this fixed? Thanks!

AnthonyByansi avatar Jul 20 '24 08:07 AnthonyByansi

Hi @saragibby Could you please review this PR? Thank you!

AnthonyByansi avatar Jul 29 '24 15:07 AnthonyByansi

Hi @alfredodeza The change has been Implemented through https://github.com/github-education-resources/codespaces-teaching-js-template/pull/47/commits/7adc61aa9c4c84dd65d49f7e1afe62d5f1274375

AnthonyByansi avatar Aug 05 '24 09:08 AnthonyByansi

@AnthonyByansi what I meant is that the image shouldn't come from a user account that uploaded it. In this case, the correct svg should be this one: https://github.com/codespaces/badge.svg

Can you make that change?

alfredodeza avatar Aug 12 '24 19:08 alfredodeza