copilot-metrics-viewer icon indicating copy to clipboard operation
copilot-metrics-viewer copied to clipboard

add Dockerfile

Open stephenjannin opened this issue 1 year ago • 2 comments

  • Include a Dockerfile for easier build (generated by Copilot :-) )
  • Slightly updated README.md to mention it

stephenjannin avatar Apr 25 '24 09:04 stephenjannin

Thanks for your contribution @stephenjannin ! It seems the Dockerfile is breaking the Azure Static Web App deployment 🤔

martedesco avatar Apr 26 '24 08:04 martedesco

Could this come from an issue accessing the secrets ? Similar to https://github.com/Azure/static-web-apps/issues/1342 ?

stephenjannin avatar Apr 26 '24 10:04 stephenjannin

@martedesco : the "skip_deploy_on_missing_secrets" should fix the GHA. The deployment will be triggered only when you merge the PR or force push on master

stephenjannin avatar Apr 30 '24 07:04 stephenjannin

Thanks for your contribution @stephenjannin ! Looks good to me 🚀

martedesco avatar Apr 30 '24 17:04 martedesco