web icon indicating copy to clipboard operation
web copied to clipboard

Update how bounty amount displays

Open GTChase opened this issue 3 years ago • 10 comments

User Story: As a contributor I want to see the value of the amount in USD when pegged to USD So that i get an accurate representation of the payout for any given bounty

Acceptance Criteria

Displaying bounty amount pegged in USD GIVEN i am on Gitcoin.co AND there is a bounty created pegged to USD WHEN i navigate to the bounty explorer OR view the details page of a bounty pegged to USD THEN all bounties that are pegged to USD should display as: [fixed amount of USD entered on bounty creation] USD in [payout token symbol selected on bounty creation] Example: 500 USD in ETH AND this same behavior should be reflected on the Bounty details page

Displaying bounty amount pegged to native token GIVEN i am on Gitcoin.co AND there is a bounty created pegged to USD WHEN i navigate to the bounty explorer OR view the details page of a bounty pegged to a native token THEN the bounty payout amount will display as ([Amount of native token entered] ETH) ([converted amount of token at that time] USD), the first value is fixed and second value is variable Example (2 ETH) (6,000 USD)

Product & Design Links: https://www.figma.com/file/8AFLrc4dx9xnMXUkWOAaAR/Existing-Bounties-Updates?node-id=123%3A622

Open Questions:

  • how do we want this to look when pegged to Native token? answered in AC

Notes/Assumptions:

GTChase avatar Apr 08 '22 13:04 GTChase

I cannot test this currently because i cannot load the bounty explorer at all.. Screen Shot 2022-04-26 at 5 13 45 PM

@nutrina

GTChase avatar Apr 26 '22 21:04 GTChase

http://gitcoin-review-10409-a81235f-1873182368.us-west-2.elb.amazonaws.com/issue/4

this shows up as "10.00 USD true" on the bounty explorer image

willsputra avatar Apr 28 '22 19:04 willsputra

This has been fixed, needs to be deployed to review

nutrina avatar May 02 '22 09:05 nutrina

This has been deployed

nutrina avatar May 03 '22 09:05 nutrina

lgtm!

willsputra avatar May 03 '22 16:05 willsputra

Displaying bounty amount pegged to native token - this AC scenario needs a few minor tweaks..

  • On the bounty explorer it doesnt display an amount at all when it is pegged to a native token.. Please show it as: THEN the bounty payout amount will display as ([Amount of native token entered] ETH) ([converted amount of token at that time] USD), the first value is fixed and second value is variable Example (2 ETH) (6,000 USD) Screen Shot 2022-05-03 at 3 48 40 PM
  • On the details page, it displays it like it does when pegged in USD which makes it really confusing for the user.. Please show it as: THEN the bounty payout amount will display as ([Amount of native token entered] ETH) ([converted amount of token at that time] USD), the first value is fixed and second value is variable Example (2 ETH) (6,000 USD) Screen Shot 2022-05-03 at 3 49 46 PM

cc. @nutrina moving back to todo to fix these two issues.

GTChase avatar May 03 '22 19:05 GTChase

@GTChase regarding your first point, this is due to the fact that the amounts are very small. This is the same behaviour in production at the moment: image

nutrina avatar May 04 '22 06:05 nutrina

Regarding the 2nd point, we should discuss this in the standup

nutrina avatar May 04 '22 07:05 nutrina

Regarding the 2nd point, this looks good to me: image

nutrina avatar May 04 '22 18:05 nutrina

This looks good now!

GTChase avatar May 09 '22 14:05 GTChase