smart_contracts
smart_contracts copied to clipboard
gitcoinco
Push Open Source Forward.
I have watch a few videos on this. And they all seem Legit is there anything that you can tell me that would change my mind otherwise good or bad
…raves/grants948.
https://github.com/gitcoinco/smart_contracts/blob/9100e1cfde32fcc7a45ec5cfbc11df5bf8d36699/contracts/bounty/BountyIndex.sol#L69 if the token address is a valid address along with it some ether is sent, the ether would be stuck up in the smart contract. If its a valid...
### Deprecated constructions Deprecated constructions: years, sha3, suicide, throw, and constant functions. **recommendation** Use keccak256 instead of sha3. Use selfdestruct instead of suicide. Use revert() instead of throw. Use view...
from @mbeacom: ``` also, I found myself running smart_contracts with testrpc quite a bit while testing things for gitcoinco/web. Do you think it'd be valuable to add a `smart_contracts` container...
If `npm install` is necessary (probably) then there should be a package.json committed, not only package-lock.json
Not sure how this is intended, but at least the specified installation does not work for me. Either npm complain about there not being package.json or does nothing. Even worse...
Requirements * right now, gitcoin bounties have a 1:1 relationship with a github issue * update so that gitcoin bounties have a n:1 relationship with a github issue * submit...
Publishing Source can make gitcoin.co appear as name in Etherscan logs instead of just hash. See this KittyCore contract for example - https://etherscan.io/address/0x06012c8cf97bead5deae237070f9587f8e7a266d#code I don't know how to do this....
If both the bounty claim, and bounty approval are in the same block a frontrunner can steal the bounty funds.
