gitbutler icon indicating copy to clipboard operation
gitbutler copied to clipboard

Type to search/filter target branch selector

Open abjorck opened this issue 1 year ago β€’ 1 comments

When opening a git project with hundreds or branches it is tedious to find the right "target" by scrolling

abjorck avatar Feb 12 '24 07:02 abjorck

Was about to open a request for this too– thanks to #2923 basically being done in #3677, unfortunately now I have 837 across the remotes I have set up for one of my repos πŸ˜…

inickt avatar May 10 '24 13:05 inickt

Hello, thanks to @estib-vega, this should be now fixed. Would you mind trying it out with the latest release (0.12.4)?

krlvi avatar Jun 12 '24 11:06 krlvi

@krlvi This is great! Definitely a nice QOL improvement. Seems to be 1 tiny UI bug where if you select the remote with your mouse, it doesn't update the UI. Functionally it seems to work though.

https://github.com/gitbutlerapp/gitbutler/assets/4574041/0f15ea98-be81-4940-bb53-7468b59ec0f7

Also might be nice if the cursor shows up when typing (or always reset the filter) but that is such a minor nit. It looks if you have previously typed to filter (and select), and then you type again, it will append, but otherwise it will erase the filter completely (what I would expect to happen every time).

inickt avatar Jun 14 '24 17:06 inickt

Dang, nice catch! Sorry about that πŸ˜…. I think this should fix that: https://github.com/gitbutlerapp/gitbutler/pull/4102

It will reset always the filter text and correctly update the UI

estib-vega avatar Jun 17 '24 19:06 estib-vega

A major bug: If you uncheck something that filters out all branches, it makes the filter button disappear, making it impossible to revert the filter. Screenshot 2024-06-18 at 6 42 31

marktoman avatar Jun 18 '24 04:06 marktoman

Great catch, I can confirm that.

What's worse is that it survives reloads!

https://github.com/gitbutlerapp/gitbutler/assets/63622/583beb0a-a4f7-470d-95cc-e7b58535c6dd

Byron avatar Jun 18 '24 05:06 Byron

Hey @marktoman πŸ‘‹ That's a big one indeed, nice catch! But I think that bug is unrelated to this issue.

This other PR should fix that, though: https://github.com/gitbutlerapp/gitbutler/pull/4103

estib-vega avatar Jun 18 '24 05:06 estib-vega

That's true, putting the feedback label back, as this issue is talking about the target branch selector.

Byron avatar Jun 18 '24 05:06 Byron

Screenshot 2024-08-15 at 15 00 44

The issues mentioned here should all be resolved. Feel free to open individual issues if more issues come up.

Caleb-T-Owens avatar Aug 15 '24 13:08 Caleb-T-Owens