sdm icon indicating copy to clipboard operation
sdm copied to clipboard

Add ability to assign FS label in parted plugin

Open ykharuzhy opened this issue 1 year ago • 4 comments

It would be great if we can set a FS label when creating partitions with parted plugin.

I did some PoC here (checked for ext4 and should work for FAT): https://github.com/ykharuzhy/sdm/commit/611edfc0ea613c3ffbfea925bec9126e52ebb7a0

Example:

sdm" --batch --burnfile "$out_image" --burn-plugin parted:"addpartition=1024,ext4,primary,overlayroot+128,ext4,primary,media" "$out_image.tmp"

ykharuzhy avatar Jun 14 '24 12:06 ykharuzhy

What would the value of this be to users?

gitbls avatar Jun 14 '24 16:06 gitbls

I use this to make rootfs overlay backed by partition, not tmpfs. Mounting by label allow to have one image for SD and NVMe.

пт, 14 чэр 2024, 19:09 карыстальнік Benn @.***> напісаў:

What would the value of this be to users?

— Reply to this email directly, view it on GitHub https://github.com/gitbls/sdm/issues/217#issuecomment-2168338938, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIHK77RD5M67CTZUJ4EBYQTZHMIUHAVCNFSM6AAAAABJKISMGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGMZTQOJTHA . You are receiving this because you authored the thread.Message ID: @.***>

ykharuzhy avatar Jun 14 '24 18:06 ykharuzhy

I'll have a look into this next week.

gitbls avatar Jun 15 '24 00:06 gitbls

This will be in the next sdm release. Thanks for the POC!

gitbls avatar Jun 23 '24 00:06 gitbls

This is included in V12.4. I'd appreciate it if you could test/verify. Thx!

gitbls avatar Jul 03 '24 19:07 gitbls

Closed due to no activity.

gitbls avatar Jul 12 '24 18:07 gitbls