Giraffe.ViewEngine icon indicating copy to clipboard operation
Giraffe.ViewEngine copied to clipboard

Add .NET 8 target framework and use string interpolation

Open gumbarros opened this issue 1 year ago • 5 comments

gumbarros avatar Feb 28 '24 00:02 gumbarros

Hi @gumbarros, thank you for your interest in this project! Do you have any specific use case in mind to use net8.0 inside this library? If not, adding that net8.0 doesn't really do much when your own app is targeting the net8.0 runtime.

nojaf avatar Feb 28 '24 08:02 nojaf

Good morning!

Nah, just added .NET 8 to see if some new analyzer suggest something you can remove if you want :)

gumbarros avatar Feb 28 '24 11:02 gumbarros

That is an interesting sentence there. What did you expect to see from what kind of analyzer potentially?

nojaf avatar Feb 28 '24 11:02 nojaf

That is an interesting sentence there. What did you expect to see from what kind of analyzer potentially?

At least in C#, I found in my projects the following analyzers: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859 https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860

I don't have the info of new analyzers for F#

gumbarros avatar Feb 28 '24 16:02 gumbarros

Analyzers are not a thing in F#. It will potentially be on the roadmap for F# 9.

nojaf avatar Feb 28 '24 16:02 nojaf