Keep original favicons when suspended

[GSPierce]

Please complete the following information when submitting a feature request or bug report.

• Extension version: v7.1.6.2
• Browser name & version: Chrome: Version 100.0.4896.75 (Official Build) (64-bit)
• Operating system & version: Win 10 10.0.19043 Build 19043

And please also do a search for your request/bug before create a new one thanks!

Suspended tabs are currently replacing the site-specific favicon with the Marvellous Suspender favicon, making it hard to find a specific tab to unsuspend when they all look the same. Is there a way to not hide the original favicons when suspended? Thanks.

[hiighpriestess]

I've been experiencing the same issue! Really frustrating, as it makes it incredibly hard to keep track of my tabs.

If I click on the suspended tab (even without unsuspending), the Marvellous Suspender favicon seems to refresh and will display the original site favicon, but it soon reverts back to the MS favicon.

I really adore this extension, so I really hope the developers are able to sort this issue out soon!

Extension version: v7.1.6.2 Browser name & version: Chrome: Version 99.0.4844.51 (Official Build) (x86_64) Operating system & version: macOS Mojave, Version 10.14.6 (18G8022)

[yinzishao]

It also bothers me so much -_-

[tubes41]

Perhaps tied to #167 ?

edit: I've noticed that the tabs where favicons work are showing as "discarded" in the chrome extension debugging page, whereas the tabs with the MS icon are showing a "suspended"

[tubes41]

Grabbed a log of the suspend / unsuspend process (see attached). Looks like gsFavIcon is building the favIconUrl object, but it's not getting saved to the suspended tab object? issue175.log

Edit: Done some further digging. The favicon is being saved to the cache correctly, and passes the validation check. Line 330 of gsTabSuspendManager.js clears the tab's favicon. After this call, I don't see the tab's favicon get updated until the tab is unsuspended...

[tubes41]

Note that using Chrome's discard option resolves the issue:

[chaoscreater]

Note that using Chrome's discard option resolves the issue:

Doesn't work regardless of whether that setting is enabled or not