onechart icon indicating copy to clipboard operation
onechart copied to clipboard

Secrets for the initContainer

Open bjarneo opened this issue 2 years ago • 1 comments

👋

Our company has been using this chart for a while, and it works as a charm. However, today we wanted an initContainer to run some migrations before the pods started, and we would need access to secrets we pass as env vars to that container. I noticed there is no such thing while looking at the template.

Can something like this be added? https://github.com/gimlet-io/onechart/blob/96a5c6b810eab90408abb034faa002f6efc25023/charts/static-site/templates/deployment.yaml#L47-L49

I assume the location is here: https://github.com/gimlet-io/onechart/blob/master/charts/common/templates/_podSpec.yaml#L13-L35

I can surely create a PR for this.

Thank you for creating this gem of a chart!

bjarneo avatar Apr 15 '24 18:04 bjarneo

After creating this issue I noticed this PR which I vote yes for! https://github.com/gimlet-io/onechart/pull/67/files

bjarneo avatar Apr 15 '24 18:04 bjarneo