react-joyride icon indicating copy to clipboard operation
react-joyride copied to clipboard

fix callback not called when skipping on first step

Open fabb opened this issue 11 months ago • 4 comments

fixes https://github.com/gilbarbara/react-joyride/issues/1121

fabb avatar May 14 '25 15:05 fabb

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

codesandbox[bot] avatar May 14 '25 15:05 codesandbox[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar May 14 '25 15:05 codesandbox-ci[bot]

@fabb @gilbarbara Can we get this merged? It's affecting a project of mine (among others who have commented or subscribed to the linked issue).

jdhenry08 avatar Jun 13 '25 19:06 jdhenry08

Hi @gilbarbara

I hope you're doing well! I wanted to follow up on PR #1172, which addresses the issue with skipProps.onClick not triggering the callback (related to issue #1121).

We're currently experiencing this bug in our production application, and this PR appears to provide the exact fix we need. The solution looks solid based on the discussion in the thread.

Would it be possible to get this merged in an upcoming release? We'd be happy to help with testing or any additional changes needed.

Thank you for your time and for maintaining this excellent library!

sjorsverhoef avatar Sep 26 '25 11:09 sjorsverhoef