llama.cpp icon indicating copy to clipboard operation
llama.cpp copied to clipboard

Fix Safari Compatibility Issue: Replace URL.parse Method in llama-server UI

Open 0x4139 opened this issue 1 year ago • 1 comments

The URL.parse method is not available in all browsers, particularly Safari, which causes the UI interface for llama-server to break. This pull request replaces the URL.parse method with the new URL() constructor to ensure compatibility across all browsers. Using new URL() provides a more standardized and widely supported way to parse URLs, resolving the issue with Safari and improving overall browser compatibility.

Fixes #8631

0x4139 avatar Jul 23 '24 12:07 0x4139

Do you think this is this related to #8631?

Yes, one of the users mentions that the web UI works on chromium, so it's definitely a compatibility issue. It also seems that the bug was introduced in #8552

0x4139 avatar Jul 23 '24 12:07 0x4139