whisper.cpp icon indicating copy to clipboard operation
whisper.cpp copied to clipboard

Change ggml.c to make it compatible with C++ compilers.

Open Alejandro-FA opened this issue 2 years ago • 5 comments

In a small cross-platform mobile project that I'm working on I've been forced to compile ggml.c with a C++ compiler (clang++). This has exposed some minor incompatibilities of ggml.c with C++ compilers, which can be easily solved.

Alejandro-FA avatar Jun 11 '23 19:06 Alejandro-FA

Are the binary files supposed to be included?

fire avatar Jul 26 '23 19:07 fire

The binary files were not supposed to be included. I have deleted them from the branch, sorry for the trouble.

Alejandro-FA avatar Jul 26 '23 20:07 Alejandro-FA

Do you know if whisper.cpp has a 1 merge commit policy? The binary files are still in the pull request. You probably need to squash.

fire avatar Jul 27 '23 01:07 fire

Do you know if whisper.cpp has a 1 merge commit policy? The binary files are still in the pull request. You probably need to squash.

I don't know if they have such a policy, but as far as I understand it is a decision to take when merging, not now.

Are you sure about the binary files? I only see 1 file changed in the pull request.

Alejandro-FA avatar Aug 01 '23 09:08 Alejandro-FA

Commit ec6c2cd79f15b0b477d1640141b05af07dc7abdd, which is part of this PR, does indeed include the binary files. You could squash your commits and force-push.

ziegenberg avatar Jun 25 '24 09:06 ziegenberg