getsentry
ci: publish vroom to GHCR and provide a tagged release on GHCR
Similar work with these PRs:
- https://github.com/getsentry/relay/pull/4532
- https://github.com/getsentry/symbolicator/pull/1635
- https://github.com/getsentry/snuba/pull/6997
- https://github.com/getsentry/sentry/pull/88181
While also trying to provide a solution (or at least an alternative) for this issue: https://github.com/getsentry/self-hosted/issues/3593
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
~~@asottile-sentry for the review, especially on required checks.~~
Ah, the failure was due to permissions. Retried from my account, let's see if it goes through.
~~@asottile-sentry for the review, especially on required checks.~~
Ah, the failure was due to permissions. Retried from my account, let's see if it goes through.
@BYK I believe it was due to this https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#pushing-container-images
When you first publish a package, the default visibility is private. To change the visibility or set access permissions, see Configuring a package's access control and visibility. You can link a published package to a repository using the user interface or command line. For more information, see Connecting a repository to a package.
We need to update the image in the deploy script as well or push to both places https://github.com/getsentry/vroom/blob/main/gocd/templates/bash/deploy.sh#L8
We need to update the image in the deploy script as well or push to both places https://github.com/getsentry/vroom/blob/main/gocd/templates/bash/deploy.sh#L8
I believe this PR already push to both places.
I believe this PR already push to both places.
Ah, you are indeed correct and Cloud Build is responsible for this.
@mdtro Hey, can you take a look over the build CI? Seems like another permission issue.