snuba
snuba copied to clipboard
ref(eap) Remove old attributes tables
The original meta attribute tables were replaced with slightly different versions. Remove the old tables.
isn't this in migration 5 already?
:x: 1 Tests Failed:
| Tests completed | Failed | Passed | Skipped |
|---|---|---|---|
| 1234 | 1 | 1233 | 3 |
View the top 1 failed tests by shortest run time
tests.migrations.test_runner test_reverse_allStack Traces | 6.71s run time
Traceback (most recent call last): File ".../tests/migrations/test_runner.py", line 328, in test_reverse_all runner.reverse_migration(migration, force=True) File ".../snuba/migrations/runner.py", line 382, in reverse_migration self._reverse_migration_impl(migration_key) File ".../snuba/migrations/runner.py", line 439, in _reverse_migration_impl migration.backwards(context, dry_run) File ".../snuba/migrations/migration.py", line 181, in backwards ops = self.backwards_ops() ^^^^^^^^^^^^^^^^^^^^ File ".../snuba_migrations/events_analytics_platform/0016_remove_old_span_attribute_table.py", line 53, in backwards_ops "index_granularity": self.granularity, ^^^^^^^^^^^^^^^^ AttributeError: 'Migration' object has no attribute 'granularity'
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard
This PR has a migration; here is the generated SQL
-- start migrations
-- forward migration events_analytics_platform : 0016_remove_old_span_attribute_table
Local op: DROP TABLE IF EXISTS spans_attributes_meta_local;
Distributed op: DROP TABLE IF EXISTS spans_attributes_meta_dist;
-- end forward migration events_analytics_platform : 0016_remove_old_span_attribute_table
-- backward migration events_analytics_platform : 0016_remove_old_span_attribute_table
-- end backward migration events_analytics_platform : 0016_remove_old_span_attribute_table