snuba icon indicating copy to clipboard operation
snuba copied to clipboard

fix AssertionError in snuba 0006_sorting_key_change migration

Open wolandspb opened this issue 1 year ago • 2 comments

If timestamp already DateTime CODEC(T64, ZSTD(1)) migration fails.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

wolandspb avatar Aug 14 '24 12:08 wolandspb

I had the same issue as https://github.com/getsentry/snuba/issues/6186 This PR should fix it.

wolandspb avatar Aug 14 '24 12:08 wolandspb

Hi, @evanh can u check this?

wolandspb avatar Aug 22 '24 07:08 wolandspb

@wolandspb I've opened https://github.com/getsentry/snuba/pull/6633 since I think we've had some issues with CI and external contributors in the past so just wanted to make things easy and open one myself. I also verified that I got the same error, and that your fix works.

MeredithAnya avatar Dec 10 '24 01:12 MeredithAnya

Thanks a lot, @MeredithAnya! Is it possible to you to check this PR too: https://github.com/getsentry/sentry/pull/81902. Its not related, but since you have CI issues Im afraid that this will can take a while too.

wolandspb avatar Dec 10 '24 08:12 wolandspb

Thanks a lot, @MeredithAnya! Is it possible to you to check this PR too: getsentry/sentry#81902. Its not related, but since you have CI issues Im afraid that this will can take a while too.

That PR is out of scope for my team, so I don't really have control over when it will get looked at, but I can let other folks know.

MeredithAnya avatar Dec 10 '24 19:12 MeredithAnya

but I can let other folks know

That would be awesome, thanks!

wolandspb avatar Dec 10 '24 20:12 wolandspb