sentry icon indicating copy to clipboard operation
sentry copied to clipboard

ref(mediators): Turn project rule updater to dataclass

Open Christinarlong opened this issue 1 year ago • 1 comments

Turns Updater -> ProjectRuleUpdater to dataclass and update uses to be explicit in passing in params (kwargs['attr'] vs .get('attr') is very inconsistent and ugly rn :[ )

Christinarlong avatar Oct 15 '24 20:10 Christinarlong

Codecov Report

Attention: Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/projects/project_rules/updater.py 98.24% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #79145      +/-   ##
==========================================
+ Coverage   78.31%   78.32%   +0.01%     
==========================================
  Files        7137     7134       -3     
  Lines      315317   314685     -632     
  Branches    51529    51419     -110     
==========================================
- Hits       246942   246488     -454     
+ Misses      61899    61733     -166     
+ Partials     6476     6464      -12     

codecov[bot] avatar Oct 15 '24 21:10 codecov[bot]