sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(anomaly detection): update alert rule details page for anomaly detection

Open mifu67 opened this issue 1 year ago • 1 comments

Screenshot 2024-08-26 at 12 08 26 PM Screenshot 2024-08-26 at 3 20 53 PM

mifu67 avatar Aug 26 '24 19:08 mifu67

mostly nit comments

although the 'dynamic' strings feels like they should be just fine as enums? can you expand on what you're seeing?

@nhsiehgit what's different is "count" instead of "static" and "change" instead of "percent"

mifu67 avatar Aug 27 '24 16:08 mifu67

:x: 1 Tests Failed:

Tests completed Failed Passed Skipped
7695 1 7694 0
View the top 1 failed tests by shortest run time
Incident Rules Form Creating a new rule creates an anomaly detection rule Incident Rules Form Creating a new rule creates an anomaly detection rule
Stack Traces | 1.15s run time
Error: expect(jest.fn()).toHaveBeenLastCalledWith(...expected)

Expected: Anything, ObjectContaining {"data": ObjectContaining {"aggregate": "count()", "dataset": "events", "detectionType": "dynamic", "environment": null, "eventTypes": ["error"], "seasonality": "auto", "sensitivity": "medium"}}
Received: ".../organizations/org-slug/alert-rules/", {"data": {"activations": [], "aggregate": "count()", "alertType": "num_errors", "comparisonDelta": null, "dataset": "events", "dateCreated": "2019-07-31T23:02:02.731Z", "dateModified": "2019-07-31T23:02:02.731Z", "detectionType": "dynamic", "environment": null, "eventTypes": ["error"], "id": undefined, "name": "My Incident Rule", "owner": undefined, "projectId": "2", "projects": ["project-slug"], "query": "", "queryType": 0, "resolveThreshold": 36, "seasonality": null, "sensitivity": "medium", "snooze": false, "status": 0, "thresholdPeriod": 1, "thresholdType": 0, "timeWindow": 60, "triggers": [{"actions": [], "alertRuleId": "4", "alertThreshold": 0, "dateCreated": "2019-09-24T18:07:47.714Z", "id": "1", "label": "critical"}]}, "error": [Function error], "method": "POST", "query": {"duplicateRule": "false", "referrer": undefined, "sessionId": undefined, "wizardV3": "true"}, "success": [Function success]}

Number of calls: 1
    at Object.<anonymous> (.../rules/metric/ruleForm.spec.tsx:335:26)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov[bot] avatar Aug 27 '24 19:08 codecov[bot]