sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(replay): Web Vital Breadcrumb Design

Open c298lee opened this issue 1 year ago • 1 comments

All web vitals fully implemented except the newest CLS design (SDK changes are required)

c298lee avatar Aug 16 '24 07:08 c298lee

Codecov Report

Attention: Patch coverage is 10.93750% with 114 lines in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../components/replays/breadcrumbs/breadcrumbItem.tsx 22.00% 39 Missing :warning:
static/app/utils/replays/highlightNode.tsx 6.45% 29 Missing :warning:
static/app/utils/replays/extractHtml.tsx 0.00% 23 Missing :warning:
static/app/utils/replays/replayReader.tsx 7.14% 13 Missing :warning:
...tatic/app/utils/replays/hooks/useCrumbHandlers.tsx 0.00% 7 Missing :warning:
static/app/utils/replays/types.tsx 0.00% 1 Missing :warning:
...views/replays/detail/breadcrumbs/breadcrumbRow.tsx 0.00% 1 Missing :warning:
...p/views/replays/detail/useVirtualizedInspector.tsx 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #76320      +/-   ##
==========================================
+ Coverage   78.15%   78.22%   +0.07%     
==========================================
  Files        6910     6895      -15     
  Lines      307183   306364     -819     
  Branches    50351    50225     -126     
==========================================
- Hits       240073   239655     -418     
+ Misses      60755    60323     -432     
- Partials     6355     6386      +31     

codecov[bot] avatar Aug 16 '24 07:08 codecov[bot]

Bundle Report

Changes will increase total bundle size by 4.65kB :arrow_up:

Bundle name Size Change
app-webpack-bundle-array-push 30.1MB 4.65kB :arrow_up:

codecov[bot] avatar Sep 03 '24 19:09 codecov[bot]