ref(replay): migrate SmartSearchbar to SearchQueryBuilder
Closes https://github.com/getsentry/sentry/issues/75006 See https://sentry.sentry.io/stories/?name=app/components/searchQueryBuilder/index.stories.tsx Used the issue's search bar as a reference.
~~One thing I had trouble with was recent searches~~ Recent searches isn't supported yet.
The flag is enabled for internal orgs only, maybe we can merge this and dogfood a bit (the new FF toggles will help :)
Demo .mov: https://drive.google.com/file/d/1DXksPM0QURpzeKqVzH8ih6ir7pS8Vhk7/view?usp=sharing
Follow-up:
- [ ]
useFetchOrganizationTags - [ ] Try sorting by
-totalValuesfor most popular tags
Omitted props: From SearchQueryBuilder: // label // onChange // disallowLogicalOperators
From SmartSearchBar (unsupported in new component) // maxMenuHeight={500} // maxQueryLength={MAX_QUERY_LENGTH} // pageFilters // prepareQuery={prepareQuery} // projectIds={projectIds} (only used for multi-project search analytics, which I don't think we use)
Codecov Report
Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
Project coverage is 78.23%. Comparing base (
2f8231f) to head (c726466).
| Files | Patch % | Lines |
|---|---|---|
| static/app/views/replays/list/replaySearchBar.tsx | 0.00% | 6 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #75552 +/- ##
==========================================
+ Coverage 73.83% 78.23% +4.40%
==========================================
Files 6824 6826 +2
Lines 303237 303129 -108
Branches 52186 52165 -21
==========================================
+ Hits 223890 237158 +13268
+ Misses 72506 59596 -12910
+ Partials 6841 6375 -466
| Files | Coverage Δ | |
|---|---|---|
| static/app/views/replays/list/replaySearchBar.tsx | 43.58% <0.00%> (-9.36%) |
:arrow_down: |
Suspect Issues
This pull request was deployed and Sentry observed the following issues:
- ‼️ Error: Unable to fetch event field values
/replays/View Issue
Did you find this useful? React with a 👍 or 👎