sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(breadcrumbs): Add drawer for breadcrumbs

Open leeandher opened this issue 1 year ago • 2 comments

This PR adds a drawer and new control interface for breadcrumbs when expanded. The new UI doesn't allow for scrolling in the breadcrumbs, and instead provides a few of them as a summary always sorted newest -> oldest (since this will show the event associated with the issue)

image

todo

  • [ ] Add tests

leeandher avatar Jun 28 '24 21:06 leeandher

Bundle Report

Changes will increase total bundle size by 4.53kB :arrow_up:

Bundle name Size Change
app-webpack-bundle-array-push 27.3MB 4.53kB :arrow_up:

codecov[bot] avatar Jun 28 '24 21:06 codecov[bot]

Codecov Report

Attention: Patch coverage is 92.04545% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (4bb6ded) to head (3a4f73c). Report is 166 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #73545      +/-   ##
==========================================
+ Coverage   78.02%   78.11%   +0.09%     
==========================================
  Files        6638     6651      +13     
  Lines      296818   297166     +348     
  Branches    51115    51166      +51     
==========================================
+ Hits       231582   232125     +543     
+ Misses      58965    58738     -227     
- Partials     6271     6303      +32     
Files Coverage Δ
...ponents/events/breadcrumbs/breadcrumbsTimeline.tsx 80.00% <100.00%> (+80.00%) :arrow_up:
...ic/app/components/events/breadcrumbs/testUtils.tsx 100.00% <100.00%> (ø)
static/app/components/events/breadcrumbs/utils.tsx 61.11% <100.00%> (+51.30%) :arrow_up:
static/app/components/timeline/index.tsx 100.00% <100.00%> (+25.80%) :arrow_up:
...ils/groupEventDetails/groupEventDetailsContent.tsx 62.22% <ø> (ø)
...ents/events/breadcrumbs/breadcrumbsDataSection.tsx 86.66% <88.46%> (+80.14%) :arrow_up:
...ts/events/breadcrumbs/breadcrumbsDrawerContent.tsx 91.48% <91.48%> (ø)

... and 149 files with indirect coverage changes

codecov[bot] avatar Jun 28 '24 21:06 codecov[bot]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TestingLibraryElementError: Unable to find an element with the text: Warning Category. This could be because the text is brok... Object.?(breadcrumbsDrawerContent.spec.tsx) View Issue
  • ‼️ TestingLibraryElementError: Unable to find an element with the text: Warning Category. This could be because the text is brok... Object.?(breadcrumbsDrawerContent.spec.tsx) View Issue
  • ‼️ TestingLibraryElementError: Unable to find an element with the text: Query Category. This could be because the text is broken... Object.?(breadcrumbsDrawerContent.spec.tsx) View Issue
  • ‼️ TestingLibraryElementError: Unable to find an element with the text: Warning Category. This could be because the text is brok... Object.?(breadcrumbsDrawerContent.spec.tsx) View Issue
  • ‼️ TestingLibraryElementError: Unable to find an element with the text: -1min. This could be because the text is broken up by mu... Object.?(breadcrumbsDrawerContent.spec.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar Jul 03 '24 21:07 sentry[bot]