sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(metrics): Expose span.duration

Open narsaynorath opened this issue 1 year ago • 3 comments

Exposes span.duration in the metrics query builder with a very limited set of available tags.

The tags that are currently suggested are span.op, span.domain, and span.action.

The other tags that are collected for all spans are: transaction, transaction.op, project, and environment. I feel like we should expose project and environment because they're so common in our app.

narsaynorath avatar May 22 '24 12:05 narsaynorath

If we want to move forward with this, should this be feature flagged? 🤔

narsaynorath avatar May 22 '24 13:05 narsaynorath

If we want to move forward with this, should this be feature flagged? 🤔

I don't think so, we do not want exclusive_time exposed for the release.

phacops avatar May 22 '24 13:05 phacops

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 77.86%. Comparing base (7eb565d) to head (6d0b74d). Report is 177 commits behind head on master.

:exclamation: Current head 6d0b74d differs from pull request most recent head 921d26f

Please upload reports for the commit 921d26f to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #71326      +/-   ##
==========================================
- Coverage   77.89%   77.86%   -0.04%     
==========================================
  Files        6525     6532       +7     
  Lines      290597   291073     +476     
  Branches    50276    50372      +96     
==========================================
+ Hits       226375   226648     +273     
- Misses      57975    58196     +221     
+ Partials     6247     6229      -18     
Files Coverage Δ
static/app/views/metrics/queryBuilder.tsx 0.00% <ø> (ø)
static/app/utils/metrics/index.tsx 30.46% <0.00%> (ø)
static/app/utils/metrics/useMetricsTags.tsx 10.52% <50.00%> (+10.52%) :arrow_up:

... and 243 files with indirect coverage changes

codecov[bot] avatar May 22 '24 16:05 codecov[bot]