sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(Activated Alerts): implement deploy activator

Open nhsiehgit opened this issue 1 year ago • 4 comments

Deploy reference a specific release being deployed to a specific environment

To activate a monitor for a deploy means to start monitoring per release AND environment for a specific Project.

This PR subscribes the monitor subscription to the creation of a ReleaseProjectEnvironment which for all intents and purposes is synonymous with "deploy"

nhsiehgit avatar May 11 '24 19:05 nhsiehgit

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

github-actions[bot] avatar May 11 '24 19:05 github-actions[bot]

Bundle Report

Changes will increase total bundle size by 57 bytes :arrow_up:

Bundle name Size Change
app-webpack-bundle-array-push 26.78MB 57 bytes :arrow_up:

codecov[bot] avatar May 11 '24 20:05 codecov[bot]

Yup looking at tests now

nhsiehgit avatar May 13 '24 17:05 nhsiehgit

hmmmm yea- i considered the JSON as well

it would definitely make it easier to parse for the client.

but i'm a little sus of sticking JSON into the db... for now it's just a short charfield, so if we want to enable JSON we'd need to update the column with a bigger size 😬

nhsiehgit avatar May 13 '24 22:05 nhsiehgit

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Project.DoesNotExist: Project matching query does not exist. sentry.tasks.process_buffer.process_incr View Issue

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar May 17 '24 16:05 sentry[bot]