sentry icon indicating copy to clipboard operation
sentry copied to clipboard

ref(rules): Update apply_rule to enqueue rules with slow conditions

Open ceorourke opened this issue 1 year ago • 1 comments

Update apply_rule to add rules with "slow" conditions (aka conditions that query Snuba) to a buffer to be evaluated in a task. If a rule with a slow condition has an action_match of "all" it will go to the buffer, and if a rule with an action_match" of "any" will go to the buffer if the "fast" conditions have failed.

Closes https://github.com/getsentry/team-core-product-foundations/issues/244

ceorourke avatar Apr 30 '24 00:04 ceorourke

Codecov Report

Attention: Patch coverage is 90.74074% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.00%. Comparing base (e924c71) to head (39bb736). Report is 31 commits behind head on master.

:exclamation: Current head 39bb736 differs from pull request most recent head b8b3127. Consider uploading reports for the commit b8b3127 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #69938   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files        6495     6495           
  Lines      289822   289866   +44     
  Branches    49930    49942   +12     
=======================================
+ Hits       231869   231909   +40     
- Misses      57541    57545    +4     
  Partials      412      412           
Files Coverage Δ
src/sentry/features/temporary.py 100.00% <100.00%> (ø)
src/sentry/rules/processing/delayed_processing.py 93.29% <ø> (-0.05%) :arrow_down:
src/sentry/rules/processing/processor.py 92.47% <90.56%> (-0.90%) :arrow_down:

... and 4 files with indirect coverage changes

codecov[bot] avatar Apr 30 '24 01:04 codecov[bot]