ref(ch-upgrades): testing ch 23.3 DONT MERGE
similar testing as https://github.com/getsentry/snuba/pull/5425 but for 23.3 - we have to upgrade to 23.3 prior to 23.8 :(
Also - in order to fix some getsentry tests, I added old_parts_lifetime setting to the config so that I could make it 1 seconds instead of the default of 480
From a practical stand point - running the tests from a clean slate works fine, its the re-run of the tests with the same data that causes problems (and not enough time to let the data be deleted, hence the forcing of that with old_parts_lifetime) so I feel pretty good that the deletion script works its just the testing around it need to be fixed
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.87%. Comparing base (
8c9047b) to head (bb82ce0). Report is 1050 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #69063 +/- ##
===========================================
+ Coverage 51.61% 79.87% +28.26%
===========================================
Files 6456 6491 +35
Lines 287219 288725 +1506
Branches 49491 49710 +219
===========================================
+ Hits 148259 230632 +82373
+ Misses 138560 57697 -80863
+ Partials 400 396 -4
| Files | Coverage Δ | |
|---|---|---|
| src/sentry/conf/server.py | 89.18% <ø> (ø) |
This pull request has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀