sentry-ruby icon indicating copy to clipboard operation
sentry-ruby copied to clipboard

Deprecate config.metrics and Sentry::Metrics

Open sl0thentr0py opened this issue 1 year ago • 3 comments

sl0thentr0py avatar Feb 04 '25 13:02 sl0thentr0py

Codecov Report

:x: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 71.74%. Comparing base (b5a4948) to head (5c96b67). :warning: Report is 119 commits behind head on master.

Files with missing lines Patch % Lines
sentry-ruby/lib/sentry/cron/monitor_check_ins.rb 0.00% 3 Missing :warning:
sentry-ruby/lib/sentry/metrics.rb 25.00% 3 Missing :warning:
sentry-ruby/lib/sentry/metrics/configuration.rb 80.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2539      +/-   ##
==========================================
+ Coverage   69.40%   71.74%   +2.33%     
==========================================
  Files         126      118       -8     
  Lines        4723     4427     -296     
==========================================
- Hits         3278     3176     -102     
+ Misses       1445     1251     -194     
Components Coverage Δ
sentry-ruby 66.98% <50.00%> (+5.03%) :arrow_up:
sentry-rails 73.28% <ø> (-14.66%) :arrow_down:
sentry-sidekiq 95.52% <ø> (+3.50%) :arrow_up:
sentry-resque 98.83% <ø> (+3.23%) :arrow_up:
sentry-delayed_job 87.87% <ø> (+36.07%) :arrow_up:
sentry-opentelemetry ∅ <ø> (∅)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 68.49% <100.00%> (+0.78%) :arrow_up:
sentry-ruby/lib/sentry/configuration.rb 85.86% <100.00%> (ø)
sentry-ruby/lib/sentry/envelope/item.rb 46.93% <ø> (+12.93%) :arrow_up:
...y-ruby/lib/sentry/interfaces/stacktrace_builder.rb 100.00% <ø> (+8.82%) :arrow_up:
sentry-ruby/lib/sentry/span.rb 86.36% <ø> (+0.03%) :arrow_up:
sentry-ruby/lib/sentry/transaction_event.rb 80.55% <ø> (+1.60%) :arrow_up:
sentry-ruby/lib/sentry/metrics/configuration.rb 88.88% <80.00%> (+4.27%) :arrow_up:
sentry-ruby/lib/sentry/cron/monitor_check_ins.rb 28.94% <0.00%> (ø)
sentry-ruby/lib/sentry/metrics.rb 57.14% <25.00%> (-1.69%) :arrow_down:

... and 4 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Feb 04 '25 13:02 codecov[bot]

Removing APIs' functionality technically is still breaking change

the server ignores these payloads completely anyway, so in that way it already 'broke'

but yeah, I also want to do the major soon but I do not have bandwidth to prepare it in the coming month or so

sl0thentr0py avatar Feb 10 '25 11:02 sl0thentr0py

but yeah, I also want to do the major soon but I do not have bandwidth to prepare it in the coming month or so

@sl0thentr0py happy to help with this

solnic avatar Feb 10 '25 12:02 solnic

closing in favor of #2726

sl0thentr0py avatar Sep 26 '25 10:09 sl0thentr0py