Don't gate request query strings and form data behind send_default_pii
This makes it consistent with behavior in other SDKs. But since it changes behavior, we will release it as part of the next major.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 98.06%. Comparing base (9446a30) to head (c6d6137).
:warning: Report is 183 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2452 +/- ##
==========================================
- Coverage 98.16% 98.06% -0.10%
==========================================
Files 126 126
Lines 4741 4708 -33
==========================================
- Hits 4654 4617 -37
- Misses 87 91 +4
| Components | Coverage Δ | |
|---|---|---|
| sentry-ruby | 98.47% <100.00%> (-0.05%) |
:arrow_down: |
| sentry-rails | 96.72% <100.00%> (-0.33%) |
:arrow_down: |
| sentry-sidekiq | 97.63% <ø> (ø) |
|
| sentry-resque | 91.42% <ø> (-1.43%) |
:arrow_down: |
| sentry-delayed_job | 95.65% <ø> (ø) |
|
| sentry-opentelemetry | 99.31% <ø> (ø) |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| sentry-rails/lib/sentry/rails/active_job.rb | 100.00% <100.00%> (ø) |
|
| sentry-ruby/lib/sentry/background_worker.rb | 100.00% <100.00%> (ø) |
|
| sentry-ruby/lib/sentry/breadcrumb.rb | 96.96% <100.00%> (ø) |
|
| sentry-ruby/lib/sentry/breadcrumb_buffer.rb | 100.00% <100.00%> (ø) |
|
| sentry-ruby/lib/sentry/check_in_event.rb | 100.00% <100.00%> (ø) |
|
| sentry-ruby/lib/sentry/client.rb | 100.00% <100.00%> (ø) |
|
| sentry-ruby/lib/sentry/configuration.rb | 98.86% <ø> (-0.03%) |
:arrow_down: |
| sentry-ruby/lib/sentry/cron/monitor_config.rb | 95.45% <100.00%> (ø) |
|
| sentry-ruby/lib/sentry/cron/monitor_schedule.rb | 100.00% <100.00%> (ø) |
|
| sentry-ruby/lib/sentry/error_event.rb | 100.00% <100.00%> (ø) |
|
| ... and 20 more |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
The failing test seems to be about new behavior rails 7.2 and will be fixed separately
Query strings should not be guarded by send_default_pii, but it should still apply for the request body. https://develop.sentry.dev/sdk/expected-features/data-handling/#sensitive-data