sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

fix(ios): Warn and do not overwrite when iOS build uses outdated source maps configuration

Open krystofwoldrich opened this issue 1 year ago • 1 comments

:loudspeaker: Type of change

  • [x] Bugfix
  • [x] New feature
  • [x] Enhancement
  • [x] Refactoring

:scroll: Description

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed submitted code
  • [ ] I added tests to verify changes
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • [ ] All tests passing
  • [ ] No breaking changes

:crystal_ball: Next steps

krystofwoldrich avatar Apr 24 '24 17:04 krystofwoldrich

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 416.55 ms 441.22 ms 24.67 ms
Size 17.73 MiB 19.94 MiB 2.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c9ca10ac3f729d1b3ef805328665aa0895+dirty 338.94 ms 354.87 ms 15.93 ms
6e8584e8f1988b33cc24c85f32711c91358905fa 447.10 ms 474.71 ms 27.61 ms
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 333.78 ms 343.94 ms 10.16 ms
25343377820b65409b646b44bc8e9bc9fbb51c8c 394.15 ms 415.12 ms 20.97 ms
f06c879d164a5bd44945c6e000e25ce3f7c14172 408.41 ms 424.54 ms 16.13 ms
15c80abcaf3bedf5d6f15c0eebefc9e7c1524da1+dirty 336.27 ms 350.58 ms 14.31 ms
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 335.72 ms 355.52 ms 19.80 ms
9c48b2c9eb6422d8d51fcf56b1b4ab7841d2ec8a 349.24 ms 385.96 ms 36.72 ms
0677344f8502b3ae15a3128bf239cf5571b92443 327.74 ms 337.14 ms 9.40 ms
544699261cd72e3efc1259ba66b138f5f70a05ed 403.40 ms 426.70 ms 23.30 ms

App size

Revision Plain With Sentry Diff
d197b5c9ca10ac3f729d1b3ef805328665aa0895+dirty 17.73 MiB 20.04 MiB 2.31 MiB
6e8584e8f1988b33cc24c85f32711c91358905fa 17.73 MiB 19.86 MiB 2.12 MiB
dadc233f906b89b35cb320c3f7d1dfaf5db0cc5d+dirty 17.73 MiB 19.75 MiB 2.02 MiB
25343377820b65409b646b44bc8e9bc9fbb51c8c 17.73 MiB 19.84 MiB 2.11 MiB
f06c879d164a5bd44945c6e000e25ce3f7c14172 17.73 MiB 19.85 MiB 2.12 MiB
15c80abcaf3bedf5d6f15c0eebefc9e7c1524da1+dirty 17.73 MiB 20.04 MiB 2.31 MiB
76d1bafa51ac0d20b127bc97b0f45201263636c3+dirty 17.73 MiB 20.04 MiB 2.31 MiB
9c48b2c9eb6422d8d51fcf56b1b4ab7841d2ec8a 17.73 MiB 19.80 MiB 2.07 MiB
0677344f8502b3ae15a3128bf239cf5571b92443 17.73 MiB 19.81 MiB 2.07 MiB
544699261cd72e3efc1259ba66b138f5f70a05ed 17.73 MiB 19.85 MiB 2.12 MiB

github-actions[bot] avatar Apr 24 '24 17:04 github-actions[bot]

Sadly the warning is basically invisible deep in Xcode logs. Closing the PR.

krystofwoldrich avatar Apr 29 '24 18:04 krystofwoldrich