sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

Add turbo_module and fabric usage to context

Open krystofwoldrich opened this issue 3 years ago • 3 comments

Description

Similarly as hermes engine

https://github.com/getsentry/sentry-react-native/blob/c95aa21497ca93aaaaf0b44d170dc39dc7bcf660/src/js/sdk.tsx#L136

tract turbo modules and fabric renderer.

krystofwoldrich avatar Oct 12 '22 10:10 krystofwoldrich

SDKs should not create tags automatically, ideally, all those tags go under the contexts, and later make them searchable via Snuba queries.

marandaneto avatar Oct 12 '22 11:10 marandaneto

Okay, I didn't know that. In that case, should we remove the hermes tag in v5 and add it to the context? Or would that cause a lot of trouble for our customers, possibly?

krystofwoldrich avatar Oct 12 '22 12:10 krystofwoldrich

Okay, I didn't know that. In that case, should we remove the hermes tag in v5 and add it to the context? Or would that cause a lot of trouble for our customers, possibly?

nope, I'd say this is a different issue, I'd add this info as part of the contexts instead of tags only.

marandaneto avatar Oct 12 '22 12:10 marandaneto

Let's make these indexed on SNUBA so we can filter events and track the adoption of the RN new architecture.

krystofwoldrich avatar Oct 14 '22 12:10 krystofwoldrich

https://github.com/getsentry/sentry-react-native/pull/2552

marandaneto avatar Oct 25 '22 12:10 marandaneto