Adds Attach Screenshot Option
Fixes #2362
:loudspeaker: Type of change
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
:scroll: Description
Adds a attachScreenshot option that sets the attachScreenshot in cocoa project and calls setAttachScreenshot in java project.
:bulb: Motivation and Context
Excited about using the new Sentry screenshot feature in React Native projects.
:green_heart: How did you test it?
Ran the sample projects.
iOS:

Android:
(Not sure what I have to do to trigger a screenshot, didn't work for me, but did verify the setting was indeed set at init)
:pencil: Checklist
- [x] I reviewed submitted code
- [ ] I added tests to verify changes
- [x] All tests passing
- [x] No breaking changes
:crystal_ball: Next steps
Thanks @PaitoAnderson I'll check what's going on on Android.
Thanks @PaitoAnderson I'll check what's going on on Android.
https://github.com/getsentry/sentry-react-native/issues/2362#issuecomment-1193763553
Thanks @marandaneto for all your work figuring out why this didn't work as I had hoped; based on the changes that need to happen before this relatively simple PR can be merged would you rather I closed this PR or leave it open?
This pull request has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
This pull request has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
Replaced by https://github.com/getsentry/sentry-react-native/pull/2610