sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

Adds Attach Screenshot Option

Open PaitoAnderson opened this issue 3 years ago • 5 comments

Fixes #2362

:loudspeaker: Type of change

  • [ ] Bugfix
  • [x] New feature
  • [ ] Enhancement
  • [ ] Refactoring

:scroll: Description

Adds a attachScreenshot option that sets the attachScreenshot in cocoa project and calls setAttachScreenshot in java project.

:bulb: Motivation and Context

Excited about using the new Sentry screenshot feature in React Native projects.

:green_heart: How did you test it?

Ran the sample projects.

iOS: image

Android: image (Not sure what I have to do to trigger a screenshot, didn't work for me, but did verify the setting was indeed set at init)

:pencil: Checklist

  • [x] I reviewed submitted code
  • [ ] I added tests to verify changes
  • [x] All tests passing
  • [x] No breaking changes

:crystal_ball: Next steps

PaitoAnderson avatar Jul 15 '22 19:07 PaitoAnderson

Thanks @PaitoAnderson I'll check what's going on on Android.

marandaneto avatar Jul 20 '22 07:07 marandaneto

Thanks @PaitoAnderson I'll check what's going on on Android.

https://github.com/getsentry/sentry-react-native/issues/2362#issuecomment-1193763553

marandaneto avatar Jul 25 '22 13:07 marandaneto

Thanks @marandaneto for all your work figuring out why this didn't work as I had hoped; based on the changes that need to happen before this relatively simple PR can be merged would you rather I closed this PR or leave it open?

PaitoAnderson avatar Jul 25 '22 14:07 PaitoAnderson

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Aug 16 '22 00:08 github-actions[bot]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Sep 07 '22 00:09 github-actions[bot]

Replaced by https://github.com/getsentry/sentry-react-native/pull/2610

marandaneto avatar Nov 15 '22 09:11 marandaneto