sentry-native Consider per-report Consent Checking

I have some patches I would like to contribute which add basic consent prompt support to Windows with crashpad.

This patchset requires patching crashpad - how do you want me to add that to your build process?

Dec 09 '19 20:12 icedtoast

Is your idea to just defer the uploader or also to put the entire crash collection behind the consent prompt? We maintain patches to crashpad on our own repo here so you can also send a PR there: https://github.com/getsentry/crashpad/

Dec 16 '19 13:12 mitsuhiko

I added basic support in #116 but I want to see if the flow can be improved.

Dec 19 '19 14:12 mitsuhiko

Thanks, yes the idea is just defer uploading until consent is given.

#116 is close to what I have, although it is "global", where I was wanting support for asking consent on a per-report basis. I implemented this passing a path to a DLL which crashpad would load and then call before uploading each report.

Would that style (per-report consent) be something you were wanting to implement? I'll have to rework my patchset in light of #116, but if you are already working in this area I'm happy to drop my local changes in favor of your solution.

Dec 20 '19 02:12 icedtoast

I think it would be nice to have this on a per-report basis somehow. The main problem is that since crashpad is out of process and everything else is in process it's kinda ugly to find a backend independent implementation for that.

Would be very happy to accept something though that makes it possible.

Dec 21 '19 11:12 mitsuhiko