sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard

Update @sentry/ember dependencies

Open azhiv opened this issue 3 years ago • 10 comments

Some of them are stale and are declared with ~, which restricts any minor updates. Also update README.md to require ember v3.24+ instead of v4+ because 3.24 is already used for testing targets via ember-try.js.

Before submitting a pull request, please take a look at our Contributing guidelines and verify:

  • [x] If you've added code that should be tested, please add tests.
  • [x] Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

azhiv avatar Jul 29 '22 09:07 azhiv

@k-fish Could you please take a look at this PR? The version of ember-auto-import is outdated and I will appreciate if you, guys, give an approve to update this dependency (along with some others as a drive-by change).

azhiv avatar Jul 29 '22 10:07 azhiv

Thanks for opening a PR! Think you'll need to update yarn.lock by running yarn!

AbhiPrasad avatar Jul 29 '22 14:07 AbhiPrasad

Hey @AbhiPrasad, thanks for pointing that out. Including the amended yarn.lock.

azhiv avatar Jul 29 '22 15:07 azhiv

@AbhiPrasad I had to also update @embroider/test-setup dev dependency as it probably caused the tests to fail.

azhiv avatar Jul 29 '22 16:07 azhiv

@AbhiPrasad I have to tag you one more time - I updated the default node version to be 12 mainly because v10 met its EOL on 30 Apr 2021 and it also failed the build for the new version of embroider.

azhiv avatar Aug 01 '22 10:08 azhiv

@getsentry/open-source

azhiv avatar Aug 02 '22 13:08 azhiv

Hey @azhiv! We unfortunately can’t accept this patch if we are bumping the default Node version. We only do this during major bumps to make sure folks don’t unexpectedly break.

See: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king

AbhiPrasad avatar Aug 02 '22 13:08 AbhiPrasad

Understood, I'll try to proceed with node v10.

azhiv avatar Aug 02 '22 13:08 azhiv

@AbhiPrasad Can you please guide me on how to test the build locally against node v10? With v12 yarn in the root folder succeeds, but when switching to v10, I get the following error:

 ~/src/sentry-javascript > update-ember-dependencies ±✚ |> yarn           
yarn install v1.22.19
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
warning Pattern ["[email protected]"] is trying to unpack in the same destination "/Users/artemz/Library/Caches/Yarn/v6/npm-react-router-6-6.3.0-3970cc64b4cb4eae0c1ea5203a80334fdd175557-integrity/node_modules/react-router-6" as pattern ["react-router-6@npm:[email protected]"]. This could result in non-deterministic behavior, skipping.
error @rollup/[email protected]: The engine "node" is incompatible with this module. Expected version ">=12.0.0". Got "10.24.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
 ✘ > ~/src/sentry-javascript > update-ember-dependencies ±✚ |> node -v
v10.24.1

After sorting this out, I'm going to run embroider-safe target which used to fail the build when using node v10. I guess I need to downgrade embrioder, but testing each version for compatibility via github actions is obviously an overkill so I'd rather prefer to perform the research locally.

azhiv avatar Aug 02 '22 13:08 azhiv

Don't have the bandwidth to take a detailed look for the next couple days - but look at https://github.com/getsentry/sentry-javascript/pull/5094 to understand our build system.

@rollup/plugin-sucrase shouldn't be used by ember - we build ember with the ember build system.

AbhiPrasad avatar Aug 02 '22 14:08 AbhiPrasad

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Aug 24 '22 00:08 github-actions[bot]