sentry-javascript-bundler-plugins icon indicating copy to clipboard operation
sentry-javascript-bundler-plugins copied to clipboard

fix: only show missing authToken warning if `release.create` is true

Open eni4sure opened this issue 10 months ago • 2 comments

Fixes #536

eni4sure avatar Mar 11 '25 18:03 eni4sure

Hi, unfortunately we cannot merge this PR as-is because it will actually change whether the release management plugin is added or not, which controls a bunch of other things too. We would need to be a little bit smarter about this.

lforst avatar Mar 12 '25 08:03 lforst

@lforst That makes sense. I pushed an update to explicitly check if both release.create and release.finalize is set to false to disable releases. That should avoid any unintended changes.

eni4sure avatar Mar 12 '25 16:03 eni4sure

Hey @eni4sure 👋 Really sorry that this PR went unnoticed for such a long time. We did quite a few refactors in the meantime. Are you still up to get this PR over the finish line? If so, could you rebase it to the latest main commit and re-check if the fix still applies correctly? If not, that's of course fine, too. Again, sorry for the delayed response!

heads-up: I'm only assigning myself to this PR so that I don't loose track of it. Doesn't mean I'm taking over but just waiting for your response :)

Lms24 avatar May 21 '25 07:05 Lms24

hey @Lms24, haven't tested but would close for now.

eni4sure avatar May 26 '25 22:05 eni4sure