sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Remove clean before test

Open runningcode opened this issue 7 months ago • 1 comments

:scroll: Description

This removes the redundant dependency on cleanTest from each test task. This still allows the test to come from the cache so it doesn't really make sense. Also add build caching for spotless format execution #skip-changelog

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] I updated the wizard if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

runningcode avatar Jun 06 '25 03:06 runningcode

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 401.98 ms 448.61 ms 46.63 ms
Size 1.58 MiB 2.09 MiB 518.66 KiB

Previous results on branch: no/optimize

Startup times

Revision Plain With Sentry Diff
d67bd0bbddd207fce8289a185328555ecc9f0d66 439.06 ms 507.98 ms 68.92 ms
7908017a84434137d07ac5647991533b692e04b5 451.30 ms 520.00 ms 68.70 ms

App size

Revision Plain With Sentry Diff
d67bd0bbddd207fce8289a185328555ecc9f0d66 1.58 MiB 2.09 MiB 518.67 KiB
7908017a84434137d07ac5647991533b692e04b5 1.58 MiB 2.08 MiB 511.07 KiB

github-actions[bot] avatar Jun 06 '25 03:06 github-actions[bot]

Ah yeah, the one about having a hermetic testing environment? Still hasn’t become a thing unfortunately.

runningcode avatar Jun 19 '25 05:06 runningcode