sentry-java
sentry-java copied to clipboard
POTEL 37d - Bump OpenTelemetry versions
:scroll: Description
val otelVersion = "1.41.0"
val otelJavaagentVersion = "2.7.0"
val otelSemanticConvetionsVersion = "1.25.0-alpha"
Sticking to semconv 1.25.0 as https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/dependencyManagement/build.gradle.kts#L49 hasn't upgraded yet.
:bulb: Motivation and Context
:green_heart: How did you test it?
:pencil: Checklist
- [ ] I reviewed the submitted code.
- [ ] I added tests to verify the changes.
- [ ] No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - [ ] I updated the docs if needed.
- [ ] Review from the native team if needed.
- [ ] No breaking change or entry added to the changelog.
- [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.
:crystal_ball: Next steps
| Messages | |
|---|---|
| :book: | Do not forget to update Sentry-docs with your feature once the pull request gets approved. |
Generated by :no_entry_sign: dangerJS against 4de72846e4a23f25751f054df415e136b79097fe
Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 403.98 ms | 429.83 ms | 25.85 ms |
| Size | 1.70 MiB | 2.29 MiB | 599.45 KiB |
Previous results on branch: feat/potel-37d-bump-otel-versions
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bf6dbe75cccd49e14a5722ddaac6ca51ffd60e88 | 398.44 ms | 468.30 ms | 69.86 ms |
| aa74a220baa6a662fb7a9c11dd6919ff677ee850 | 519.46 ms | 602.02 ms | 82.56 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bf6dbe75cccd49e14a5722ddaac6ca51ffd60e88 | 1.70 MiB | 2.29 MiB | 599.31 KiB |
| aa74a220baa6a662fb7a9c11dd6919ff677ee850 | 1.70 MiB | 2.29 MiB | 599.31 KiB |
I just tested it and the following code shows that it cares about the underlying string, not where the reference is coming from:
otelSpan.setAttribute(InternalSemanticAttributes.TEST1, "test1");
otelSpan.setAttribute(InternalSemanticAttributes.TEST2, "test2");
String test1 = span.getAttributes().get(InternalSemanticAttributes.TEST1);
System.out.println(test1); // prints "test2"
String test2 = span.getAttributes().get(InternalSemanticAttributes.TEST2);
System.out.println(test2); // prints "test2"
I wasn't able to find any usage of the "old" SemanticAttributes class in the opentelemetry-java-instrumentation code base for v2.7.0 anymore. In older versions it was still being used.