sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

POETL 37c - Skip `PROCESS_COMMAND_ARGS` attribute

Open adinauer opened this issue 1 year ago • 2 comments

:scroll: Description

PROCESS_COMMAND_ARGS can be very large and cause other payload to be removed.

:bulb: Motivation and Context

Defaults that work for most users.

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar Aug 28 '24 09:08 adinauer

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against c108d82eaf682239d41430ae46beba418967da71

github-actions[bot] avatar Aug 28 '24 09:08 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 434.98 ms 467.79 ms 32.81 ms
Size 1.70 MiB 2.29 MiB 599.45 KiB

Previous results on branch: feat/potel-37c-skip-process-command-args-attribute

Startup times

Revision Plain With Sentry Diff
d4382c54aedbb1593ef8dc3a05580f184912f7e8 420.00 ms 472.48 ms 52.48 ms

App size

Revision Plain With Sentry Diff
d4382c54aedbb1593ef8dc3a05580f184912f7e8 1.70 MiB 2.29 MiB 599.31 KiB

github-actions[bot] avatar Aug 28 '24 09:08 github-actions[bot]