sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

POTEL 37b - No longer selectively copy OTel span attributes

Open adinauer opened this issue 1 year ago • 2 comments

:scroll: Description

We're copying all of attribues as of (https://github.com/getsentry/sentry-java/pull/3593). This means we no longer need to selectively copy some of them.

:bulb: Motivation and Context

Remove unnecessary code.

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar Aug 28 '24 09:08 adinauer

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against dc91b84231c8f571850a558e8e6c6c296f64f2d4

github-actions[bot] avatar Aug 28 '24 09:08 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 453.72 ms 483.76 ms 30.03 ms
Size 1.70 MiB 2.29 MiB 599.45 KiB

Previous results on branch: feat/potel-37b-remove-selective-attribute-copying

Startup times

Revision Plain With Sentry Diff
bfc2f884963ff27d7bb781c782ac956f38606fd7 456.92 ms 530.96 ms 74.04 ms
9294b06895e4266e8ae0c7f5bd3d5a92a9060233 438.15 ms 502.29 ms 64.15 ms
33d3c1bf192b4eed584941c31246addd180db804 349.24 ms 358.60 ms 9.36 ms

App size

Revision Plain With Sentry Diff
bfc2f884963ff27d7bb781c782ac956f38606fd7 1.70 MiB 2.29 MiB 599.45 KiB
9294b06895e4266e8ae0c7f5bd3d5a92a9060233 1.70 MiB 2.29 MiB 599.31 KiB
33d3c1bf192b4eed584941c31246addd180db804 1.70 MiB 2.29 MiB 599.45 KiB

github-actions[bot] avatar Aug 28 '24 09:08 github-actions[bot]