sentry-java
sentry-java copied to clipboard
POTEL 39 - Use RECORD_ONLY sampling decision if performance is disabled
:scroll: Description
Also fixes a bug where isTraceSampling was used instead of isTracingEnabled.
:bulb: Motivation and Context
:green_heart: How did you test it?
:pencil: Checklist
- [ ] I reviewed the submitted code.
- [ ] I added tests to verify the changes.
- [ ] No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - [ ] I updated the docs if needed.
- [ ] Review from the native team if needed.
- [ ] No breaking change or entry added to the changelog.
- [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.
:crystal_ball: Next steps
| Messages | |
|---|---|
| :book: | Do not forget to update Sentry-docs with your feature once the pull request gets approved. |
Generated by :no_entry_sign: dangerJS against 7ebd37cc09ee139ed82039bfd3bb91ac5ddd7b13
Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 470.98 ms | 537.14 ms | 66.16 ms |
| Size | 1.70 MiB | 2.29 MiB | 599.45 KiB |
Previous results on branch: feat/potel-39-record-only-if-performance-disabled
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e74261b3780ae5b7a618b7f0044af299fed859d3 | 409.25 ms | 427.44 ms | 18.19 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e74261b3780ae5b7a618b7f0044af299fed859d3 | 1.70 MiB | 2.29 MiB | 599.45 KiB |