sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

POTEL 36 - POC Capture OpenTelemetry Events

Open adinauer opened this issue 1 year ago • 2 comments

:scroll: Description

OpenTelemetry spans can have events attached. This PR allows us to capture exceptions from ExceptionEventData into Sentry if the captureOpenTelemetryEvents option is enabled.

:bulb: Motivation and Context

Allows us to capture more errors. Doesn't require extra Sentry dependencies on the application for capturing errors - the agent alone is enough to capture errors.

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar Jul 11 '24 07:07 adinauer

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against eee5b2989f07477ddeba5986d6bc541c67f34326

github-actions[bot] avatar Jul 11 '24 07:07 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 390.00 ms 439.42 ms 49.42 ms
Size 1.58 MiB 2.21 MiB 642.21 KiB

Previous results on branch: feat/poc-capture-otel-events

Startup times

Revision Plain With Sentry Diff
eab21c911a9b29f84d35fc6b6a5f117dcdb79b61 373.65 ms 471.24 ms 97.59 ms
ec63bca06e2fe4f78172e288a3656e30079a34e6 387.26 ms 503.32 ms 116.06 ms

App size

Revision Plain With Sentry Diff
eab21c911a9b29f84d35fc6b6a5f117dcdb79b61 1.58 MiB 2.21 MiB 641.59 KiB
ec63bca06e2fe4f78172e288a3656e30079a34e6 1.58 MiB 2.21 MiB 641.84 KiB

github-actions[bot] avatar Jul 11 '24 07:07 github-actions[bot]