sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

POC - Use correct options on re-init

Open adinauer opened this issue 1 year ago • 2 comments

:scroll: Description

On multi init we now only do the bare minimum with the new options. Since the new options might not be used, defer init of certain things until we know whether the new options are actually being used (replaced on global scope).

We can build on top of this to control re-init behaviour once we've decided on which route we want to go there.

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar Jul 02 '24 12:07 adinauer

Fails
:no_entry_sign: Please consider adding a changelog entry for the next release.
Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POC - Use correct options on re-init ([#3540](https://github.com/getsentry/sentry-java/pull/3540))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by :no_entry_sign: dangerJS against bec16db0be8632116809cf871a0f2448e37b3c7a

github-actions[bot] avatar Jul 02 '24 12:07 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 427.43 ms 515.63 ms 88.20 ms
Size 1.70 MiB 2.29 MiB 599.60 KiB

Baseline results on branch: 8.x.x

Startup times

Revision Plain With Sentry Diff
a59fca29342f9ee762aefa59d4928457427b81d3 560.08 ms 658.80 ms 98.71 ms

App size

Revision Plain With Sentry Diff
a59fca29342f9ee762aefa59d4928457427b81d3 1.70 MiB 2.29 MiB 599.77 KiB

github-actions[bot] avatar Jul 02 '24 12:07 github-actions[bot]

Closed in favor of https://github.com/getsentry/sentry-java/pull/3674

adinauer avatar Sep 02 '24 09:09 adinauer