Parse and use `send-default-pii` and `max-request-body-size` from `sentry.properties`
:scroll: Description
We now parse and use send-default-pii and max-request-body-size from sentry.properties.
-
max-request-body-sizewas already being parsed but never applied toSentryOptions -
send-default-piiwas neither parsed nor applied
:bulb: Motivation and Context
As of 8.0.0-alpha.2 our Sentry OpenTelemetry Java Agent has been released and is supposed to be a vital part in our future Performance instrumentation. Some features (e.g. error reporting) are currently still based on the integrations that existed before.
Some data is only sent when certain options are enabled (see PR title). We never parsed those until now, meaning our OpenTelemetry Agent Init wasn't able to utilize all of the functionality Sentry offers.
NOTE: There might be more options, that aren't parsed yet. We should investigate and fix. Here's an issue for that: https://github.com/getsentry/sentry-java/issues/3535
:green_heart: How did you test it?
:pencil: Checklist
- [ ] I reviewed the submitted code.
- [ ] I added tests to verify the changes.
- [ ] No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - [ ] I updated the docs if needed.
- [ ] Review from the native team if needed.
- [ ] No breaking change or entry added to the changelog.
- [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.
:crystal_ball: Next steps
| Messages | |
|---|---|
| :book: | Do not forget to update Sentry-docs with your feature once the pull request gets approved. |
Generated by :no_entry_sign: dangerJS against ef21d8c28c23dc1bb3ded689e31bbcf09402f7e1
Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 423.20 ms | 499.43 ms | 76.23 ms |
| Size | 1.70 MiB | 2.29 MiB | 599.77 KiB |
Previous results on branch: feat/parse-more-external-options
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7dc921ac32e23e28b26aaaa24e43e5522f091eff | 454.49 ms | 522.39 ms | 67.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7dc921ac32e23e28b26aaaa24e43e5522f091eff | 1.70 MiB | 2.29 MiB | 599.50 KiB |