sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Report dropped spans

Open stefanosiano opened this issue 1 year ago • 2 comments

:scroll: Description

added span data category for client reports added dropped span report when recording lostEnvelopeItem added dropped span report on beforeSend and eventProcessor filtering (SentryClient) and backpressure and sampleRate (Hub)

:bulb: Motivation and Context

Closes https://github.com/getsentry/sentry-java/issues/3527

:green_heart: How did you test it?

Unit tests

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

stefanosiano avatar Jun 28 '24 15:06 stefanosiano

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against adcfd0329c7e2473db52f927a2cc26ad8d7e1f87

github-actions[bot] avatar Jun 28 '24 15:06 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 399.60 ms 472.17 ms 72.57 ms
Size 1.70 MiB 2.28 MiB 593.48 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
baaf6371cb120f45ad4fed59e8b97e65e3381cfd 462.32 ms 579.22 ms 116.90 ms
28c9a83af55b119517dbd2fcf74975fb5822907b 416.98 ms 479.90 ms 62.92 ms
201048a0cf146f24a001d1c7997aae2ef84b23c3 418.62 ms 481.67 ms 63.05 ms
7ab32b6ab8bc72b973328a00840eb192b151b59f 373.62 ms 480.61 ms 106.99 ms
b172d4ed57bfa46dfac6bee0216bea7d0126b253 352.92 ms 446.50 ms 93.58 ms
3d8bd2ba0c81c9aa6084fa222f9a7706cf5e8d92 364.76 ms 469.98 ms 105.22 ms
1e05e43aac4e7f22213e0ec71fa5a89a74588c91 411.00 ms 467.29 ms 56.29 ms
c554ca260c5f0fa79a30d592f6c0e08a850a5014 383.78 ms 449.84 ms 66.06 ms
0bd723b1c59af639c4a86bbade526e0108096f8e 375.20 ms 452.41 ms 77.20 ms
99a51e2957c3044db1b481b67e733b42ee267926 405.11 ms 479.65 ms 74.54 ms

App size

Revision Plain With Sentry Diff
baaf6371cb120f45ad4fed59e8b97e65e3381cfd 1.72 MiB 2.27 MiB 558.42 KiB
28c9a83af55b119517dbd2fcf74975fb5822907b 1.70 MiB 2.28 MiB 592.00 KiB
201048a0cf146f24a001d1c7997aae2ef84b23c3 1.70 MiB 2.28 MiB 592.32 KiB
7ab32b6ab8bc72b973328a00840eb192b151b59f 1.70 MiB 2.27 MiB 584.63 KiB
b172d4ed57bfa46dfac6bee0216bea7d0126b253 1.72 MiB 2.29 MiB 578.09 KiB
3d8bd2ba0c81c9aa6084fa222f9a7706cf5e8d92 1.72 MiB 2.29 MiB 577.53 KiB
1e05e43aac4e7f22213e0ec71fa5a89a74588c91 1.70 MiB 2.28 MiB 590.89 KiB
c554ca260c5f0fa79a30d592f6c0e08a850a5014 1.70 MiB 2.27 MiB 582.25 KiB
0bd723b1c59af639c4a86bbade526e0108096f8e 1.72 MiB 2.29 MiB 578.09 KiB
99a51e2957c3044db1b481b67e733b42ee267926 1.72 MiB 2.29 MiB 576.34 KiB

Previous results on branch: feat/report-dropped-spans

Startup times

Revision Plain With Sentry Diff
0bd6ff3221bee1792cd383de8082beee63997c9d 429.51 ms 497.54 ms 68.03 ms
8007b45b35b1a384acbb5d268372aea73d63c782 374.00 ms 435.50 ms 61.50 ms

App size

Revision Plain With Sentry Diff
0bd6ff3221bee1792cd383de8082beee63997c9d 1.70 MiB 2.28 MiB 593.54 KiB
8007b45b35b1a384acbb5d268372aea73d63c782 1.70 MiB 2.28 MiB 593.48 KiB

github-actions[bot] avatar Jun 28 '24 15:06 github-actions[bot]

Can you please also take care of merging this into the 8.x.x branch 🙏 (most likely via main)

adinauer avatar Jul 01 '24 11:07 adinauer

Can you please also take care of merging this into the 8.x.x branch 🙏 (most likely via main)

https://github.com/getsentry/sentry-java/pull/3536

stefanosiano avatar Jul 01 '24 16:07 stefanosiano