sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Change OkHttp events from spans to measurements

Open stefanosiano opened this issue 1 year ago • 2 comments

Description

We charge performance per span, so we can remove all sub-spans of the http.client span, changing them to measurements. This could also improve readability of the span waterfall. We have a "workaround" that automatically collapses http.client sub-spans, but that's not ideal. Slack discussion: https://sentry.slack.com/archives/GUCRT2B70/p1719330898362759?thread_ts=1719323921.345899&cid=GUCRT2B70

stefanosiano avatar Jun 25 '24 16:06 stefanosiano

Span attributes, measurements are something else we don’t want to keep using in SDKs.

cleptric avatar Jun 25 '24 16:06 cleptric

We can create a sample and compare the result with the current implementation to check the developer experience

stefanosiano avatar Jun 26 '24 12:06 stefanosiano