sentry-java
sentry-java copied to clipboard
POTEL 2 - Promote OpenTelemetry Span attributes
:scroll: Description
:bulb: Motivation and Context
Sentry features like "Requests" need certain attributes to work, e.g. span op should be "METHOD URL", response status code should be in span data.
:green_heart: How did you test it?
:pencil: Checklist
- [ ] I reviewed the submitted code.
- [ ] I added tests to verify the changes.
- [ ] No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - [ ] I updated the docs if needed.
- [ ] Review from the native team if needed.
- [ ] No breaking change or entry added to the changelog.
- [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.
:crystal_ball: Next steps
| Fails | |
|---|---|
| :no_entry_sign: | Please consider adding a changelog entry for the next release. |
| Messages | |
|---|---|
| :book: | Do not forget to update Sentry-docs with your feature once the pull request gets approved. |
Instructions and example for changelog
Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.
Example:
## Unreleased
- POTEL 2 - Promote OpenTelemetry Span attributes ([#3402](https://github.com/getsentry/sentry-java/pull/3402))
If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.
Generated by :no_entry_sign: dangerJS against c1a10f46660238afe46529680fc71c85e63c7361
Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 471.35 ms | 530.26 ms | 58.91 ms |
| Size | 1.70 MiB | 2.29 MiB | 598.04 KiB |
Baseline results on branch: 8.x.x
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a373f020dc423eab02ff263f005494d00c57e2c4 | 372.81 ms | 432.96 ms | 60.15 ms |
| dcad3c9309c1849fe21f1d4dceaa0a7990477d1e | 400.04 ms | 479.67 ms | 79.62 ms |
| 3e1e45bf7179435cf8da8c7d2ee1511bb585485e | 373.72 ms | 439.33 ms | 65.60 ms |
| 9428efa5bd61a12862f4cc5e22dce8597e464893 | 389.31 ms | 481.67 ms | 92.37 ms |
| 34db09fa45d95fbd4a0756cae22791b83c399e7d | 362.68 ms | 443.02 ms | 80.34 ms |
| 6f168826c814df0d6651918b2f7ff0e7ece4c639 | 426.16 ms | 494.15 ms | 67.99 ms |
| 9f2c8552fd8bf28926a24cb82be26f6a48a50183 | 424.20 ms | 506.34 ms | 82.14 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a373f020dc423eab02ff263f005494d00c57e2c4 | 1.70 MiB | 2.28 MiB | 596.35 KiB |
| dcad3c9309c1849fe21f1d4dceaa0a7990477d1e | 1.70 MiB | 2.28 MiB | 596.35 KiB |
| 3e1e45bf7179435cf8da8c7d2ee1511bb585485e | 1.70 MiB | 2.28 MiB | 596.32 KiB |
| 9428efa5bd61a12862f4cc5e22dce8597e464893 | 1.70 MiB | 2.28 MiB | 597.68 KiB |
| 34db09fa45d95fbd4a0756cae22791b83c399e7d | 1.70 MiB | 2.28 MiB | 596.37 KiB |
| 6f168826c814df0d6651918b2f7ff0e7ece4c639 | 1.70 MiB | 2.28 MiB | 596.37 KiB |
| 9f2c8552fd8bf28926a24cb82be26f6a48a50183 | 1.70 MiB | 2.28 MiB | 596.32 KiB |