sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Hubs/Scopes Merge 42b - Merge fingerprints from all scopes

Open adinauer opened this issue 1 year ago • 3 comments

:scroll: Description

Merge fingerprints from all scopes instead of only using the first list found.

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar Apr 29 '24 06:04 adinauer

@romtsn do you already know if we should merge them or not?

adinauer avatar Apr 29 '24 06:04 adinauer

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against 0ef21d804bbc7a3960c699f420beeb2e76a4dc92

github-actions[bot] avatar Apr 29 '24 06:04 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 399.21 ms 458.45 ms 59.24 ms
Size 1.70 MiB 2.28 MiB 595.69 KiB

Previous results on branch: feat/hsm-42b-merge-fingerprints

Startup times

Revision Plain With Sentry Diff
b0861c30e662108bdf6c5594fe068886ad866649 358.15 ms 484.00 ms 125.85 ms

App size

Revision Plain With Sentry Diff
b0861c30e662108bdf6c5594fe068886ad866649 1.70 MiB 2.28 MiB 595.69 KiB

github-actions[bot] avatar Apr 29 '24 06:04 github-actions[bot]