sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Hubs/Scopes Merge 42 - Remove `Hub`

Open adinauer opened this issue 1 year ago • 2 comments

#skip-changelog

:scroll: Description

Remove Hub class as it's no longer being used. Byebye 👋 .

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar Apr 25 '24 11:04 adinauer

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against edb7a6af2e5886cc7b8b7b5db913737111494f2b

github-actions[bot] avatar Apr 25 '24 11:04 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 381.68 ms 472.85 ms 91.17 ms
Size 1.70 MiB 2.28 MiB 595.65 KiB

Previous results on branch: feat/hsm-42-remove-hub

Startup times

Revision Plain With Sentry Diff
54a9cb5ab325f04b7e892a6ce97a74f7d719f2b9 426.14 ms 492.98 ms 66.84 ms

App size

Revision Plain With Sentry Diff
54a9cb5ab325f04b7e892a6ce97a74f7d719f2b9 1.70 MiB 2.28 MiB 595.65 KiB

github-actions[bot] avatar Apr 25 '24 12:04 github-actions[bot]