sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Hubs/Scopes Merge 41 - Use `SentryOptions.empty()`

Open adinauer opened this issue 1 year ago • 2 comments

#skip-changelog

:scroll: Description

:bulb: Motivation and Context

Creating new SentryOptions implies also creating things like executor service that are costly to create. SentryOptions.empty() already delays some of those costly things, however we should also fix https://github.com/getsentry/sentry-java/issues/2541 as a follow up.

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar Apr 25 '24 09:04 adinauer

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against 12dda5961a4aa5414dbf23954aa8c0211e303cfd

github-actions[bot] avatar Apr 25 '24 09:04 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 430.06 ms 494.71 ms 64.65 ms
Size 1.70 MiB 2.28 MiB 595.72 KiB

Previous results on branch: feat/hsm-41-empty-options

Startup times

Revision Plain With Sentry Diff
bf02f25754ffbae471081b8e9f2164b15db38d9e 348.40 ms 395.62 ms 47.22 ms

App size

Revision Plain With Sentry Diff
bf02f25754ffbae471081b8e9f2164b15db38d9e 1.70 MiB 2.28 MiB 595.65 KiB

github-actions[bot] avatar Apr 25 '24 09:04 github-actions[bot]