sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Add ttid/ttfd contribution flags

Open markushi opened this issue 1 year ago • 2 comments

:scroll: Description

Attaches the ttid/ttfd contribution flags to all spans within a txn, if the txn contains a ttid/ttfd span.

:bulb: Motivation and Context

Relevant docs PR: https://github.com/getsentry/develop/pull/1250/files Relevant discussion on Notion: https://www.notion.so/sentry/span-contribution-9b5a0979a81645789db6877593729cf4

:green_heart: How did you test it?

Added tests

:pencil: Checklist

  • [x] I reviewed the submitted code.
  • [x] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

markushi avatar Apr 25 '24 07:04 markushi

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against 7a040c0b9cd56bf8edfc203da0090fc1a4bb3dab

github-actions[bot] avatar Apr 26 '24 05:04 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 403.85 ms 471.84 ms 67.98 ms
Size 1.70 MiB 2.28 MiB 592.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0810952c95d04ff7e1b4be22b386cec9c79016d4 364.51 ms 468.08 ms 103.57 ms
61981dc1039b766300d6e38e82ccacb439387cb7 388.65 ms 454.96 ms 66.31 ms
baaf6371cb120f45ad4fed59e8b97e65e3381cfd 428.12 ms 520.40 ms 92.28 ms
1ae2ec606b8151dc0fe7fca19b4ed041b47840c0 353.85 ms 419.71 ms 65.85 ms
c7e2fbc59ddc599ea7fe0bf4cd1e11a9e34722af 377.85 ms 426.35 ms 48.50 ms
b172d4ed57bfa46dfac6bee0216bea7d0126b253 412.60 ms 492.68 ms 80.08 ms
4e260b39672c0cc6383209cec9f3300ac5596e36 378.73 ms 454.18 ms 75.45 ms
93a76ca3ed5e22b37a521784f4b601668bfa7e07 377.41 ms 448.22 ms 70.81 ms
93a76ca3ed5e22b37a521784f4b601668bfa7e07 381.08 ms 459.22 ms 78.14 ms
7b7964f423f45db68b01e66b1b6ce08dacb3e7b6 363.27 ms 455.32 ms 92.05 ms

App size

Revision Plain With Sentry Diff
0810952c95d04ff7e1b4be22b386cec9c79016d4 1.72 MiB 2.27 MiB 558.21 KiB
61981dc1039b766300d6e38e82ccacb439387cb7 1.70 MiB 2.28 MiB 592.12 KiB
baaf6371cb120f45ad4fed59e8b97e65e3381cfd 1.72 MiB 2.27 MiB 558.42 KiB
1ae2ec606b8151dc0fe7fca19b4ed041b47840c0 1.70 MiB 2.27 MiB 584.63 KiB
c7e2fbc59ddc599ea7fe0bf4cd1e11a9e34722af 1.72 MiB 2.29 MiB 576.40 KiB
b172d4ed57bfa46dfac6bee0216bea7d0126b253 1.72 MiB 2.29 MiB 578.09 KiB
4e260b39672c0cc6383209cec9f3300ac5596e36 1.72 MiB 2.27 MiB 554.95 KiB
93a76ca3ed5e22b37a521784f4b601668bfa7e07 1.72 MiB 2.29 MiB 576.75 KiB
93a76ca3ed5e22b37a521784f4b601668bfa7e07 1.72 MiB 2.29 MiB 576.75 KiB
7b7964f423f45db68b01e66b1b6ce08dacb3e7b6 1.70 MiB 2.28 MiB 592.12 KiB

Previous results on branch: feat/app-start-ttid-ttfd-span-tagging

Startup times

Revision Plain With Sentry Diff
4fa2c5682b560f82cc5883cfee57cb18bf195bbe 403.10 ms 527.82 ms 124.72 ms
6a610adc8ad4fba32a1b6531811dded3e14e9ea4 384.41 ms 441.60 ms 57.19 ms

App size

Revision Plain With Sentry Diff
4fa2c5682b560f82cc5883cfee57cb18bf195bbe 1.70 MiB 2.28 MiB 592.53 KiB
6a610adc8ad4fba32a1b6531811dded3e14e9ea4 1.70 MiB 2.28 MiB 592.50 KiB

github-actions[bot] avatar Apr 26 '24 05:04 github-actions[bot]