sentry-java
sentry-java copied to clipboard
Hubs/Scopes Merge 40 - `Scopes.isEnabled` now checks `getClient().isEnabled()`
:scroll: Description
:bulb: Motivation and Context
Since Scopes are forked much more frequently than Hub was, we can no longer store isEnabled as a property on Scopes as it would only affect a very limited scope (:D). By asking client we should by default now have the same state globally unless a customer sets a different client.
:green_heart: How did you test it?
:pencil: Checklist
- [ ] I reviewed the submitted code.
- [ ] I added tests to verify the changes.
- [ ] No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - [ ] I updated the docs if needed.
- [ ] Review from the native team if needed.
- [ ] No breaking change or entry added to the changelog.
- [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.
:crystal_ball: Next steps
| Messages | |
|---|---|
| :book: | Do not forget to update Sentry-docs with your feature once the pull request gets approved. |
Generated by :no_entry_sign: dangerJS against 4a8497805724a7b16991d5199ffc7c1aaf5f4ca7
Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 408.63 ms | 481.92 ms | 73.29 ms |
| Size | 1.70 MiB | 2.28 MiB | 595.70 KiB |
Previous results on branch: feat/hsm-40-enabled-checks-client
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c16d388fa3252d00dca561c6576c3a7d61502eaf | 385.02 ms | 475.14 ms | 90.12 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c16d388fa3252d00dca561c6576c3a7d61502eaf | 1.70 MiB | 2.28 MiB | 595.70 KiB |